Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDEProblem constructor issues #507

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

ErikQQY
Copy link
Member

@ErikQQY ErikQQY commented Sep 26, 2023

Tested locally, this patch may fix all the issues

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #507 (29aa1ad) into master (9162505) will increase coverage by 1.89%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
+ Coverage   16.23%   18.12%   +1.89%     
==========================================
  Files          50       50              
  Lines        3727     3730       +3     
==========================================
+ Hits          605      676      +71     
+ Misses       3122     3054      -68     
Files Coverage Δ
src/problems/sde_problems.jl 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ErikQQY
Copy link
Member Author

ErikQQY commented Sep 26, 2023

Test failings are caused by version conflicts

@ChrisRackauckas ChrisRackauckas merged commit 75605b1 into SciML:master Sep 26, 2023
54 of 71 checks passed
@ErikQQY ErikQQY deleted the qqy/fix_constructor_issue branch September 30, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants